Can no longer open candidates in separate hozironal/vertical splits

[blaenk]

See #4 for what I mean.

Lately when I attempt to do so I get this message:

apply: No such action ‘helm-ext-ff-buffer-action-horizontal-split’ for this source

Here is the backtrace:

Debugger entered--Lisp error: (cl-assertion-failed ((or (eq action actions) (rassq action actions) (byte-code-function-p action) (and (listp action) (functionp action))) "No such action `%s' for this source"))
  cl--assertion-failed((or (eq action actions) (rassq action actions) (byte-code-function-p action) (and (listp action) (functionp action))) "No such action `%s' for this source" nil (helm-ext-ff-buffer-action-horizontal-split))
  helm-exit-and-execute-action(helm-ext-ff-buffer-action-horizontal-split)
  (progn (helm-exit-and-execute-action 'helm-ext-ff-buffer-action-horizontal-split))
  (if helm-alive-p (progn (helm-exit-and-execute-action 'helm-ext-ff-buffer-action-horizontal-split)) (error "Running helm command outside of context"))
  (progn (if helm-alive-p (progn (helm-exit-and-execute-action 'helm-ext-ff-buffer-action-horizontal-split)) (error "Running helm command outside of context")))
  helm-ext-ff-buffer-execute-horizontal-split()
  funcall-interactively(helm-ext-ff-buffer-execute-horizontal-split)
  call-interactively(helm-ext-ff-buffer-execute-horizontal-split nil nil)
  command-execute(helm-ext-ff-buffer-execute-horizontal-split)
  read-from-minibuffer(#("[shapes] pattern: " 0 18 (face helm-minibuffer-prompt)) nil (keymap (67108903 . ace-jump-helm-line) (tab . helm-execute-persistent-action) (f13 lambda nil (interactive) (helm-select-nth-action 12)) (f12 lambda nil (interactive) (helm-select-nth-action 11)) (f11 lambda nil (interactive) (helm-select-nth-action 10)) (f10 lambda nil (interactive) (helm-select-nth-action 9)) (f9 . my--helm-toggle-scroll-bar) (f8 lambda nil (interactive) (helm-select-nth-action 7)) (f7 lambda nil (interactive) (helm-select-nth-action 6)) (f6 lambda nil (interactive) (helm-select-nth-action 5)) (f5 lambda nil (interactive) (helm-select-nth-action 4)) (f4 lambda nil (interactive) (helm-select-nth-action 3)) (f3 lambda nil (interactive) (helm-select-nth-action 2)) (f2 lambda nil (interactive) (helm-select-nth-action 1)) (menu-bar keymap (help-menu keymap (describe keymap (describe-mode . helm-help)))) (help keymap (109 . helm-help)) (23 . my-backward-delete-word) (f1 lambda nil (interactive) (helm-select-nth-action 0)) (8 keymap (109 . helm-help) (104 . undefined) (8 . undefined) (99 . helm-customize-group) (4 . helm-enable-or-switch-to-debug)) (20 . helm-toggle-resplit-and-swap-windows) (C-tab . undefined) (67108897 . helm-toggle-suspend-update) (3 keymap (57 . helm-execute-selection-action-at-nth-+9) (56 . helm-execute-selection-action-at-nth-+8) (55 . helm-execute-selection-action-at-nth-+7) (54 . helm-execute-selection-action-at-nth-+6) (53 . helm-execute-selection-action-at-nth-+5) (52 . helm-execute-selection-action-at-nth-+4) (51 . helm-execute-selection-action-at-nth-+3) (50 . helm-execute-selection-action-at-nth-+2) (49 . helm-execute-selection-action-at-nth-+1) (63 . helm-help) (110 . #f(compiled-function () (interactive nil) #<bytecode 0x404de755>)) (62 . helm-toggle-truncate-line) (21 . helm-refresh) (6 . helm-follow-mode) (9 . helm-copy-to-buffer) (11 . helm-kill-selection-and-quit) (25 . helm-yank-selection) (37 . helm-exchange-minibuffer-and-header-line) (95 . helm-toggle-full-frame) (45 . helm-swap-windows)) (67108987 . helm-enlarge-window) (67108989 . helm-narrow-window) (19 . undefined) (24 keymap (57 . helm-execute-selection-action-at-nth-+9) (56 . helm-execute-selection-action-at-nth-+8) (55 . helm-execute-selection-action-at-nth-+7) (54 . helm-execute-selection-action-at-nth-+6) (53 . helm-execute-selection-action-at-nth-+5) (52 . helm-execute-selection-action-at-nth-+4) (51 . helm-execute-selection-action-at-nth-+3) (50 . helm-execute-selection-action-at-nth-+2) (49 . helm-execute-selection-action-at-nth-+1) (2 . helm-resume-list-buffers-after-quit) (98 . helm-resume-previous-session-after-quit) (6 . helm-quit-and-find-file)) (11 . helm-delete-minibuffer-contents) (67108896 . helm-toggle-visible-mark) (0 . helm-toggle-visible-mark) (C-M-up . helm-scroll-other-window-down) (C-M-down . helm-scroll-other-window) (M-prior . helm-scroll-other-window-down) (M-next . helm-scroll-other-window) (12 . helm-recenter-top-bottom-other-window) (15 . helm-next-source) (10 . helm-execute-persistent-action) (26 . helm-select-action) (9 . helm-execute-persistent-action) (13 . helm-maybe-exit-minibuffer) (left . helm-previous-source) (right . helm-next-source) (7 . helm-keyboard-quit) (22 . helm-next-page) (27 keymap (110 . next-history-element) (112 . previous-history-element) (115 . undefined) (5 . helm-display-all-sources) (1 . helm-show-all-in-this-source-only) (85 . helm-unmark-all) (97 . helm-mark-all) (109 . helm-toggle-all-marks) (41 . helm-next-visible-mark) (40 . helm-prev-visible-mark) (91) (32 . helm-toggle-visible-mark) (33554454 . helm-scroll-other-window-down) (25 . helm-scroll-other-window-down) (22 . helm-scroll-other-window) (12 . helm-reposition-window-other-window) (111 . helm-previous-source) (62 . helm-end-of-buffer) (60 . helm-beginning-of-buffer) (118 . helm-previous-page)) (next . helm-next-page) (prior . helm-previous-page) (C-up . helm-follow-action-backward) (C-down . helm-follow-action-forward) (16 . helm-previous-line) (14 . helm-next-line) (up . helm-previous-line) (down . helm-next-line) keymap (18 . helm-minibuffer-history) (23 . my-backward-delete-word) (21 . my-backward-kill-line) (menu-bar keymap (minibuf "Minibuf" keymap (previous menu-item "Previous History Item" previous-history-element :help "Put previous minibuffer history element in the minibuffer") (next menu-item "Next History Item" next-history-element :help "Put next minibuffer history element in the minibuffer") (isearch-backward menu-item "Isearch History Backward" isearch-backward :help "Incrementally search minibuffer history backward") (isearch-forward menu-item "Isearch History Forward" isearch-forward :help "Incrementally search minibuffer history forward") (return menu-item "Enter" exit-minibuffer :key-sequence "\015" :help "Terminate input and exit minibuffer") (quit menu-item "Quit" abort-recursive-edit :help "Abort input and exit minibuffer") "Minibuf")) (10 . exit-minibuffer) (13 . exit-minibuffer) (7 . minibuffer-keyboard-quit) (C-tab . file-cache-minibuffer-complete) (9 . self-insert-command) (XF86Back . previous-history-element) (up . previous-line-or-history-element) (prior . previous-history-element) (XF86Forward . next-history-element) (down . next-line-or-history-element) (next . next-history-element) (27 keymap (114 . previous-matching-history-element) (115 . next-matching-history-element) (112 . previous-history-element) (110 . next-history-element))) nil nil "apply" t)
  helm-read-pattern-maybe("[shapes] pattern: " nil nil nil nil nil nil)
  helm-internal((helm-source-projectile-buffers-list helm-source-projectile-files-list helm-source-projectile-projects) nil "[shapes] pattern: " nil nil "*helm projectile*" nil nil nil)
  apply(helm-internal ((helm-source-projectile-buffers-list helm-source-projectile-files-list helm-source-projectile-projects) nil "[shapes] pattern: " nil nil "*helm projectile*" nil nil nil))
  helm((helm-source-projectile-buffers-list helm-source-projectile-files-list helm-source-projectile-projects) nil "[shapes] pattern: " nil nil "*helm projectile*" nil nil nil)
  apply(helm ((helm-source-projectile-buffers-list helm-source-projectile-files-list helm-source-projectile-projects) nil "[shapes] pattern: " nil nil "*helm projectile*" nil nil nil))
  helm(:sources (helm-source-projectile-buffers-list helm-source-projectile-files-list helm-source-projectile-projects) :buffer "*helm projectile*" :truncate-lines nil :prompt "[shapes] pattern: ")
  helm-projectile()
  (if (and (not arg) (projectile-project-p)) (helm-projectile) (helm-find-files nil))
  my-open-file(nil)
  funcall-interactively(my-open-file nil)
  call-interactively(my-open-file nil nil)
  command-execute(my-open-file)

[blaenk]

This is because https://github.com/emacs-helm/helm/commit/d6dfb8f1e now verifies that the action exists in the source.

[blaenk]

It'd be nice if helm-ext-ff-define-split could take an additional optional parameter for the helm source and then call helm-add-action-to-source on that source for each generated action.