decluttering-card icon indicating copy to clipboard operation
decluttering-card copied to clipboard

Card takes up space in a vertical stack card even when all content is hidden

Open ScottG489 opened this issue 2 years ago • 0 comments

Checklist:

  • [x] I updated to the latest version available
  • [x] I cleared the cache of my browser

Release with the issue: 0.6.3

Browser and Operating System: N/A (issue replicates on Google TV in Kiosk browser, Google Chrome on Ubuntu, Google Chrome on Mac, etc)

Description of problem: The decluttering card still takes up space even when all its contents are hidden. Since this is a wrapper card I can see how it would be difficult to know when all it's content is hidden, though.

It isn't completely the fault of this card as it seems like it does try to detect this and hide itself. However, some cards don't hide themselves properly and I think we could try to be more robust in how we hide ourselves.

Additional information: The only idea I have here is in addition to how we check if child cards are hidden, we could also hide ourselves if the size they are taking up is 0? You can see here that the offending card (that should be applying display: none but doesnt) has no dimensions: Screen Shot 2023-01-04 at 1 16 48 PM but the decluttering-card still does since we don't apply display: none: Screen Shot 2023-01-04 at 1 18 11 PM

ScottG489 avatar Jan 04 '23 18:01 ScottG489