curve-dao-contracts icon indicating copy to clipboard operation
curve-dao-contracts copied to clipboard

Wrong integer assigned to year

Open F041 opened this issue 2 years ago • 4 comments

WEEK: constant(uint256) = 7 * 86400  # all future times are rounded by week
MAXTIME: constant(uint256) = 4 * **365** * 86400  # 4 years
MULTIPLIER: constant(uint256) = 10 ** 18

year = 365.25 days

https://en.wikipedia.org/wiki/Year

F041 avatar May 09 '22 07:05 F041

Can you provide any additional sources? I don't trust Wikipedia, anyone can modify an article.

iamdefinitelyahuman avatar May 15 '22 13:05 iamdefinitelyahuman

I have done extensive research into the matter and concluded that it is hard to determine how many days are in a year. Is it 365 days? Is it 365.25? Is there a wider conspiracy to hide the truth? We will unfortunately likely never know.

charlie-eth avatar May 15 '22 13:05 charlie-eth

At Curve, we define year as 365 days. It's a so-called "Curve Year"

michwill avatar May 15 '22 15:05 michwill

Integers... how do they work? image

skellet0r avatar May 16 '22 02:05 skellet0r