curve-contract icon indicating copy to clipboard operation
curve-contract copied to clipboard

Published 20 hours ago • verified publisher icon curvefi

chore: make calc_withdraw_one_coin simulation consistent with _calc_withdraw_one_coin

Open michaelhly opened this issue 3 years ago • 5 comments

What I did

Change calc_withdraw_one_coin in simulation.py to represent the source of truth instead of approximation.

How I did it

Made calc_withdraw_one_coin in simulation.py to exhibit the same behavior as _calc_withdraw_one_coin

How to verify it

Added test

michaelhly avatar Nov 21 '20 05:11 michaelhly

Ohh very nice

michwill avatar Nov 21 '20 17:11 michwill

Hmm...not sure what to do about these timeouts. @iamdefinitelyahuman @michwill any tips?

michaelhly avatar Nov 21 '20 22:11 michaelhly

Yeah, idk why timeouts

michwill avatar Nov 25 '20 07:11 michwill

Seems the new test in tests/pools/common/unitary/test_remove_liquidity_one_coin.py is timing out when running against certain pools. Does anything weird happen when it runs locally against these pools?

iamdefinitelyahuman avatar Nov 25 '20 12:11 iamdefinitelyahuman

Seems the new test in tests/pools/common/unitary/test_remove_liquidity_one_coin.py is timing out when running against certain pools. Does anything weird happen when it runs locally against these pools?

I will give that a try and report back.

michaelhly avatar Nov 29 '20 22:11 michaelhly