refactor branch: FAQ automatically being added to RSS feed

[robincornett]

I imported a set of FAQ to a local site, one where I'd started with the refactor branch, reverted to master, and am back on the refactor branch. Testing my RSS feed for something else and realized that it's full of the FAQ, which I do remember seeing as a setting in the master branch, but hadn't turned on. Here's the entry from the DB for faq_options:

a:7:{s:5:"htype";s:2:"h3";s:6:"expand";s:4:"true";s:7:"exspeed";s:3:"200";s:6:"extext";s:9:"Read More";s:10:"redirectid";s:4:"none";s:6:"single";s:8:"question";s:4:"arch";s:9:"questions";}

Not sure if the check for the old RSS key itself is maybe off (if I remove the ! from line 289 in legacy.php the feed is fine), or if something else needs to be tweaked, but the key for rss is empty in my options table.

[norcross]

I'll need to see what's up with the RSS. that was always sort of a pain.

[robincornett]

I would think that even if a user wanted to add FAQ to the feed, they would want them added to posts, rather than replace the posts ($.02). I've used this code in the past to add custom post types to a main feed without losing the posts, if it might be useful to you for this:

https://gist.github.com/robincornett/62e96b6d2d25e0828e5c