hugo-theme-massively icon indicating copy to clipboard operation
hugo-theme-massively copied to clipboard

Tag support

Open rseabra opened this issue 2 years ago • 3 comments

These changes add the support for tags. You can see how they look like at https://teatro.1407.org/

The tag cloud could probably use some additional love, but it's good enough for me, for now.

rseabra avatar Dec 02 '22 13:12 rseabra

Hi, I can't see what is failing I try to see logs and it just shows me a black screen with something rolling on the top left corner, if there's something I need to fix, please let me know.

rseabra avatar Dec 06 '22 09:12 rseabra

Hey @rseabra, thanks for the contribution!

Hi, I can't see what is failing I try to see logs and it just shows me a black screen with something rolling on the top left corner, if there's something I need to fix, please let me know.

The Netlify error appears to be the same as the CI error on GitHub Actions for the hugo min version e2e test. Are you able to see these logs?

If not, here is the part that is failing:

Error: Error building site: failed to render pages: render of "Massively" failed: "/home/runner/work/hugo-theme-massively/hugo-theme-massively/layouts/_default/rss.xml:9:19": execute of template failed: template: _default/rss.xml:9:19: executing "_default/rss.xml" at <.Site.Config.Service...>: can't evaluate field RSS in type services.Config

The hugo max version e2e test has passed successfully, so perhaps this is a backwards compatibility issue with Hugo v0.54.0?

curtiscde avatar Dec 06 '22 18:12 curtiscde

Hi Curtis,

Maybe it is, I am too new to Hugo and Go to be able to tell.

What I can tell is that the RSS files seem to generate fine (eg https://teatro.1407.org/index.xml )

But if that's the case, if you want to maintain compatibility with such an old Hugo version, maybe you can skip the proposed addition of layouts/_default/rss.xml? ( https://github.com/curtiscde/hugo-theme-massively/compare/master...rseabra:hugo-theme-massively:tag-support#diff-3fb10c6a0e1801f8c8a23a6858a8710151ae674fd98589294786ecb97e8220e2 )

Best regards, Rui

rseabra avatar Dec 06 '22 20:12 rseabra