vscode-parse-tree icon indicating copy to clipboard operation
vscode-parse-tree copied to clipboard

Removing tree sitter hack and upgrading dependencies

Open bra1nDump opened this issue 2 years ago • 6 comments

Upgrading dependencies to get the build going on mac M1

bra1nDump avatar Jun 27 '22 09:06 bra1nDump

#29 Is why we can remove custom build script

bra1nDump avatar Jun 27 '22 09:06 bra1nDump

Hmm I tried to build and run this one locally, but when I run the extension, I get the following error message:

rejected promise not handled within 1 second: RuntimeError: abort(Assertion failed: undefined). Build with -s ASSERTIONS=1 for more info.
/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:102
stack trace: RuntimeError: abort(Assertion failed: undefined). Build with -s ASSERTIONS=1 for more info.
	at oe (/Users/pokey/src/vscode-parse-tree/node_modules/web-tree-sitter/tree-sitter.js:1:6761)
	at k (/Users/pokey/src/vscode-parse-tree/node_modules/web-tree-sitter/tree-sitter.js:1:4462)
	at he (/Users/pokey/src/vscode-parse-tree/node_modules/web-tree-sitter/tree-sitter.js:1:7991)
	at xe (/Users/pokey/src/vscode-parse-tree/node_modules/web-tree-sitter/tree-sitter.js:1:9810)
	at /Users/pokey/src/vscode-parse-tree/node_modules/web-tree-sitter/tree-sitter.js:1:47405
	at runMicrotasks (<anonymous>)
	at processTicksAndRejections (node:internal/process/task_queues:96:5)

Is it working for you? cc/ @wenkokke

pokey avatar Jun 29 '22 14:06 pokey

Maybe its worth splitting the upgrade and the removal of the tree sitter hack.

Update: works fine on my M1 mac. Built with docker.

bra1nDump avatar Jun 30 '22 08:06 bra1nDump

Thanks, I used this branch to be able to build on M1 (wasn't able to compile web-tree-sitter otherwise)

phillco avatar Jul 23 '22 01:07 phillco

The error reported above comes from tree-sitter itself https://github.com/tree-sitter/tree-sitter/blob/a882d0b036b0da23cde5caa1325089b4ca4750ba/lib/binding_web/exports.json#L8

wenkokke avatar Aug 23 '22 13:08 wenkokke

The patch for 0.20.4 includes the ___cxa_atexit, which is needed by one of the languages, so moving away will likely break things.

wenkokke avatar Aug 23 '22 13:08 wenkokke

Closing in favour of https://github.com/cursorless-dev/vscode-parse-tree/pull/68, which is very similar, but doesn't bump things

pokey avatar Sep 27 '23 13:09 pokey