cursorless icon indicating copy to clipboard operation
cursorless copied to clipboard

Published 20 hours ago • verified publisher icon cursorless-dev

Fix test fixture upgrade scripts

Open SimeonC opened this issue 3 years ago • 2 comments

Fixed the v1 to v2 script to preserve order and not drop any values.

SimeonC avatar Sep 08 '22 12:09 SimeonC

I think we should split this PR into two:

  • one to fix the fixture upgrade scripts, and
  • one to upgrade typescript and refactor type hints in makeGraph.ts

I believe these two pieces are completely orthogonal, and the former is more imperative, while the latter is causing the problems. Make sense?

pokey avatar Sep 18 '22 14:09 pokey

Sure we could do that. I haven't had the time to come back to look at whether the fix for the docs is just some missing new config or it needs a refactor. Sorry I'm taking so long to get round to finishing this - don't mind if someone else who has more time than me picks this up and splits it into 2 PRs.

SimeonC avatar Sep 19 '22 10:09 SimeonC

ok @SimeonC I factored out the typescript stuff into https://github.com/cursorless-dev/cursorless/pull/1166 and https://github.com/cursorless-dev/cursorless/pull/1167, and made some tweaks. lmk if you have any objections

pokey avatar Dec 09 '22 18:12 pokey

Thanks for updating and completing it, looks good to me!

SimeonC avatar Dec 11 '22 11:12 SimeonC