cursorless icon indicating copy to clipboard operation
cursorless copied to clipboard

Investigate why partial type definition being coalesced to non partial isn't a TypeScript compiler

Open phillco opened this issue 1 year ago • 2 comments

NTS: The actual type of the interface is requirements?: Partial<ScopeIteratorRequirements>. This should really be a tsc compile error but it wasn't. We therefore started to read properties on hints when some of those properties could be undefined which threw an exception

Originally posted by @phillco in https://github.com/cursorless-dev/cursorless/pull/2739#discussion_r1924122919

phillco avatar Jan 21 '25 17:01 phillco

Just flagging for passive followup later

phillco avatar Jan 21 '25 17:01 phillco

I created the smallest possible example. No warnings from typescript.

https://github.com/cursorless-dev/cursorless/pull/2745

AndreasArvidsson avatar Jan 21 '25 23:01 AndreasArvidsson