cursorless icon indicating copy to clipboard operation
cursorless copied to clipboard

Generate Examples -- Continued

Open trillium opened this issue 11 months ago • 38 comments

This is following on from the work of #940 Might resolve:

  • #1744
  • #215
  • #866

This is currently a draft PR

  • Last updated 2024-10-04

Latest updates

  • Migrate more type usage from custom to @cursorless/common
  • Refactor loadingFixture
  • Rebased and fixed merge conflicts
  • Resolved @cursorless/common import errors
  • Switched to using some @cursorless/common types
    • More will need to be done on this

ToDos Immediate

  • [ ] Render clipboard interactions in finalState
  • [ ] Resolve type issues
    • [ ] Update generateHtml types
  • [ ] Get during state rendering
  • [ ] Get pendingDelete state to render
  • [ ] Resolve some bugs in the generation around creating selections

ToDos IceBox

  • [ ] Create animation out of initialState, during, and finalState
  • [ ] Define some kind of internal API so it can be called properly or something like that
Screenshot image
Older Screenshots image

Current issues

  • The during step that shows selection for deletion isn't being hit
    • Haven't updated the code to capture a pendingDeletion selection yet (loadFixtures.ts)
  • Color scheme is very bad, will need to pick something better eventually

Older changes

Summary of older changes
  • .yml files are successfully loaded via getStaticProps and passed to TestCaseComponentPage
  • Updated to Shiki 1.4 from Shiki 0.x
  • Brought in CSS from the codepen file linked in #940 (link)
  • forked main
  • Cherry picked the 3 commits from #940
4e0b81cc SimeonC         All working with tests                                                           
3d2e85ff pre-commit-ci.. [pre-commit.ci] auto fixes from pre-commit.com hooks                             
47ca6352 SimeonC         wip: Delete workspace.json for cherry-pick - git cherry pick 070c870 - Delete .. 
  • Moved cursorless-rx/ ... /generate-exmples folder to packages/generate-examples to conform with monorepo
  • Updated loadFixture directory to point correctly to cursorless-vscode-e2e recorded folder
  • Resolved an error in packages/generate-examples/src/lib/generateHtml.ts @ SelectionParser.parse that made pnpm build fail
    • This might not be the right solution, but it the code it working again
  • Populated results from loadFixture with original data -- as of yet unused
  • Ran relevant pnpm install/setup commands

Checklist

  • [ ] I have added tests
  • [ ] I have updated the docs and cheatsheet
  • [ ] I have not broken the cheatsheet

trillium avatar Mar 25 '24 19:03 trillium