curl icon indicating copy to clipboard operation
curl copied to clipboard

ssl: Avoid explicitly setting verifypeer to 1

Open orgads opened this issue 1 year ago • 3 comments

It is the default, just like verifyhost.

orgads avatar May 19 '24 09:05 orgads

I was wondering also about the lengthy documentation of the differences between 1 and 2 for CURLOPT_SSL_VERIFYHOST. It looks like the effective default is TRUE (I couldn't find 2 anywhere), and there is no difference for current versions between 1 and 2, so maybe the documentation should not state the difference in the main description? It can be stated later in a comment, that previous versions had a difference between 1 and 2 and describe this difference.

Same goes for CURLOPT_DOH_SSL_VERIFYHOST.

orgads avatar May 19 '24 09:05 orgads

I can agree to this change. But I would also like:

  1. the code removed, not commented. The entire else clause is unused then.
  2. the same logic applied to the proxy and doh equivalent options

bagder avatar May 19 '24 21:05 bagder

I can agree to this change. But I would also like:

  1. the code removed, not commented. The entire else clause is unused then.
  2. the same logic applied to the proxy and doh equivalent options

Done

orgads avatar May 20 '24 07:05 orgads

Thanks!

bagder avatar May 25 '24 21:05 bagder