SCINet icon indicating copy to clipboard operation
SCINet copied to clipboard

Published 20 hours ago • verified publisher icon cure-lab

Forward path retuns with None in case stack is > 2

Open Pet222 opened this issue 2 years ago • 1 comments

https://github.com/cure-lab/SCINet/blob/1a3f231a9c3e11c9a2ee384d3d19cbb5a2039ebb/models/SCINet.py#L373

In case the stack is > 2 it seems there is no return value given thus the forward path returns with None.

  1. unclear how the test in table-6 was performed for stack > 2 when it is not implemented in the repo
  2. suggestion: adding to the end of stack if-elif" a piece of code with "else raise NotImplementedError" would be useful.

Pet222 avatar Apr 28 '22 06:04 Pet222

Thanks for your asking. We will check this problem with the code we are running on.

VEWOXIC avatar Apr 28 '22 12:04 VEWOXIC