MagicDrive icon indicating copy to clipboard operation
MagicDrive copied to clipboard

No Cross Attention between Seq Embedding and E_map

Open haibao-yu opened this issue 1 year ago • 2 comments

Thanks for your great work! I have a question about your implementation:

  • In Figure 3, the embeded road map is interacted with Seq Embedding and then added to input feature. However, I find the embeded road map is directly added to input feature in your implementation. Can you check it is right implementation?

https://github.com/cure-lab/MagicDrive/blob/6038a24de9fc4df641a9775aab3f735a3c590589/magicdrive/networks/unet_addon_rawbox.py#L743-L850

haibao-yu avatar Sep 10 '24 15:09 haibao-yu

We follow the implementation of ControlNet, where the control signal (map) is first added with x (noisy latent) and then goes through the copied encoder block. The whole file you referred to is the encoder from Figure 3 (not just the conv block).

flymin avatar Sep 13 '24 02:09 flymin

This issue is stale because it has been open for 7 days with no activity. If you do not have any follow-ups, the issue will be closed soon.

github-actions[bot] avatar Sep 26 '24 16:09 github-actions[bot]