cupy icon indicating copy to clipboard operation
cupy copied to clipboard

[backport] restore CUB histogram and bincount

Open chainer-ci opened this issue 1 year ago • 3 comments

Backport of #8950 by @grlee77

chainer-ci avatar Feb 22 '25 05:02 chainer-ci

/test mini

kmaehashi avatar Feb 22 '25 12:02 kmaehashi

Hmm, CI failed :thinking:

https://ci.preferred.jp/r/job/186898

FAILED cupy_tests/statistics_tests/test_histogram.py::TestCubHistogram::test_histogram
E        ACTUAL: array([ 1. ,  1.9,  2.8,  3.7,  4.6,  5.5,  6.4,  7.3,  8.2,  9.1, 10. ],
E             dtype=float32)
E        DESIRED: array([ 1.      ,  1.9     ,  2.8     ,  3.7     ,  4.6     ,  5.5     ,
E               6.4     ,  7.3     ,  8.2     ,  9.099999, 10.      ],
E             dtype=float32)

kmaehashi avatar Feb 23 '25 09:02 kmaehashi

Looks like the test catches 9.1 != 9.099999

Are we using allclose with a tolerance?

jakirkham avatar Feb 26 '25 00:02 jakirkham

We no longer maintain v13.x.

leofang avatar Oct 28 '25 01:10 leofang