cupy icon indicating copy to clipboard operation
cupy copied to clipboard

Add remez to cupyx.scipy.signal

Open andfoy opened this issue 1 year ago • 10 comments

See #7403

As per an internal discussion in Gitter, the implementation of remez will defer its call to scipy.signal, since there wouldn't be much gains from trying to compute the exchange algorithm (which is mostly serial) in GPU. Also, the usual filter sizes are small in length, thus also reducing the potential gains from a GPU implementation

andfoy avatar Apr 12 '24 00:04 andfoy

@takagi, I've just updated the PR to call remez from SciPy, as we discussed with @ev-br on Gitter

andfoy avatar Jun 14 '24 21:06 andfoy

/test mini

takagi avatar Jun 18 '24 02:06 takagi

I appreciate your effort that you once implemented GPU kernels and considered their effectiveness.

takagi avatar Jun 18 '24 02:06 takagi

What is still needed here?

jakirkham avatar Jul 29 '24 03:07 jakirkham

Seems that we have a few CI failures. Would you take a look at them, @andfoy?

FAILED cupyx_tests/scipy_tests/signal_tests/test_fir_filter_design.py::TestRemez::test_fs_validation[mod0]	
FAILED cupyx_tests/scipy_tests/signal_tests/test_fir_filter_design.py::TestRemez::test_fs_validation[mod1]	
TypeError: object of type 'int' has no len()

takagi avatar Jul 29 '24 07:07 takagi

@takagi I cannot reproduce any of these errors locally

imagen

andfoy avatar Aug 02 '24 16:08 andfoy

/test mini

kmaehashi avatar Aug 07 '24 05:08 kmaehashi

/test mini

takagi avatar Aug 20 '24 02:08 takagi

/test mini

takagi avatar Aug 23 '24 06:08 takagi