Aaron Kromer
Aaron Kromer
Just to clarify, this is only for PRs. If someone takes an issue, but doesn't submit a PR it is released back for others correct?
Is there a way this could be integrated into the PR comments? Maybe look for some term followed by one or more :+1:
I'm confused, is this related to #10?
Do you plan on this being a star type rating (maybe allow half stars?). Or more written feedback?
:+1: This was my biggest concern originally. This is definitely something I'd like to see. Just a random thought, but since you're using auth through GitHub, maybe inspect all the...
We may want to link to the matcher protocol that was add in #567. @elado thanks for reporting this, does [lib/rspec/matchers/matcher_protocol.rb](https://github.com/rspec/rspec-expectations/blob/master/lib/rspec/matchers/matcher_protocol.rb) provide the details you seek?
> I'm not sure how to make the `:return` option fit into `spy`, though; `spy` already accepts a hash of message/return value pairs and I don't really want to make...
> The problem that `spy(...)` already applies `as_null_object`. `spy` literally is `double.as_null_object`. So it's a bit silly to do `spy.as_null_object` because you're calling `as_null_object` twice. Dipping into the implementation details...
> That would work, but it bothers me that in an expression like `spy.as_null_object(:return => nil)`, `spy` doesn't do different than `double` even though it normally does. I can see...
I've forked it for now just to make sure it's kept around: https://gist.github.com/cupakromer/a40d975e9c958733cf08