Cuong Manh Le

Results 70 comments of Cuong Manh Le

I could not find a Mac Intel for testing https://go-review.googlesource.com/c/go/+/560955, any help on verifying the CL is welcome. cc @golang/darwin

> Maybe should we check if there is any performance improvement by backporting the current `maphash_purego` implementation to `runtime/hash64`? > > Idk, I checked the history and it seems that...

> > What do you mean by "backporting the current `maphash_purego` implementation to `runtime/hash64`"? The purego implementation should be updated to stay up-to-date with runtime one, to improve hash collisions...

I have just hit this again with current tip: https://ci.chromium.org/ui/p/golang/builders/try/gotip-windows-386/b8766941830696722705/overview Re-open the issue to see if it still be problem.

There's another one: https://ci.chromium.org/ui/p/golang/builders/try/gotip-windows-386/b8766892579985845249/overview Sounds like we should increase the allowed threads from 5 to a bigger number, probably 10.

> @cuonglm why do you think 10 will work better than 5? > 5 was selected as per this logic I saw the comment said that "sysmon and others", without...

It seems to me this is the problem with lazy importing, go/types ureader works well.

It seems to me this is unfortunate. - The `main.go:5:2` part of error message is the current position in the source code, not part of the error message emited by...

It seems to me that using `.` as argument to `--dir` causes `wasmtime` confusing: ``` $ wasmtime run --dir=. main 8 Bad file number [] open ./non-existent-file: Bad file number...