cui
> Hey, sorry if I wasn't clear, I didn't suggest that we to remove this helper, it is actually useful. I meant we should update its implementation in other modules,...
Hello, Please Review this pr.
@fjl can you help to review this pr?
> I don't think this change is essential, but if you really want to change it, please adopt the diff below. > > ```diff > diff --git a/cmd/devp2p/runtest.go b/cmd/devp2p/runtest.go >...
will this be merged?
In my case, this rpc can be used to clear tx pool when benchmark the chain using tools like https://github.com/0gfoundation/evmchainbench or https://github.com/cuiweixie/adventure/tree/leo/contract-deploy. Whose gas price is fixed generally, but basefee...
@fjl Let me explain: try to run this test on master code base: ``` func TestXORBytesInexactOverlap(t *testing.T) { // Error case 1: dst and x have inexact overlap data :=...
@fjl here is the ORBytes case with master codebase, same as this pr: ``` func TestXORBytesInexactOverlap(t *testing.T) { // Error case 1: dst and x have inexact overlap data :=...
The pr try to keep acting like the not asm version before this pr.
> I still think it's bad. At least we should document the requirements more clearly. And possibly there should be checks on it. When using `subtle.XORBytes`, it will panic if...