cui fliter
cui fliter
friendly ping!
friendly ping!
> [@cuishuang](https://github.com/cuishuang) seeing that you have made a contribution recently, how may I be able to get someone to review/merge a PR? ref: https://go.dev/doc/contribute
> What is the proposed criteria to decide when vet should issue a report? It is hard to decide whether to accept a vet proposal without this being specified. We...
> I'm surprised that there are so many misuses of the `append` function. Yes, if using sli[i] for assignment, there is no such problem, but many people like me are...
> I took a look at several of these reports. Most looks good. Some things to discuss. Here are my notes. > > These all look like good reports to...
After communicating with the two maintainers and receiving very good suggestions, we decided not to add a new analyzer, but to add these features based on the previous appends analyzer....
> Yes, major feature changes to analyzers included in vet do need proposals. Thanks. I have moved the code to the `appends` directory. Some comments may need to be optimized....
> Additionally, through extensive practice, I have encountered several challenges and gained some insights: How do we balance false positives and omissions? Should we aim to comprehensively identify similar issues...
> We can try to list all of the stdlib functions that might be used to intentionally append to a slice, but my intuition is that this will not be...