geeps icon indicating copy to clipboard operation
geeps copied to clipboard

[code detail] useless param in ClientLib::read_batch

Open lcytzk opened this issue 7 years ago • 1 comments

First, thanks for your paper and codes, it helps me a lot. And my question listed below.

Clientlib.cpp line 349 the param stat never used. In the whole function, stat only occurs in line 395, but it is a local param inside a if statement, so is the stat useless or it is just a mistake that stat in line 395 should be the value which get from a caller. preupdate_batch also has stat but noe used.

lcytzk avatar Sep 01 '17 06:09 lcytzk

Ah, that is a good catch. Actually, this stat param was just used for profiling and debugging purposes. Maybe I should have removed it to make the code cleaner.

cuihenggang avatar Mar 19 '18 15:03 cuihenggang