dropchop icon indicating copy to clipboard operation
dropchop copied to clipboard
verified publisher icon cugos

Fix tests/phantomJS

Open mapsam opened this issue 7 years ago • 1 comments

@nickpeihl pointed out PhantomJS is broken, and therefore all of our tests aren't working in #269. This means that PRs are red or "pending" and codeship doesn't deploy any changes to master. To get the jQuery security fix out, I went ahead and removed tests in https://github.com/cugos/dropchop/commit/7842bccd0cc91d17150fbead4f6c26227f408445 but we should get these up and running again (or refactor the test suite).

mapsam avatar Jan 22 '18 18:01 mapsam

Just a little proof that codeship is 👍 with tests commented out

screen shot 2018-01-22 at 10 29 47 am

jQuery security updates have been shipped.

mapsam avatar Jan 22 '18 18:01 mapsam