vscode icon indicating copy to clipboard operation
vscode copied to clipboard

No space between step keywords and step text in Korean dialect

Open Likilee opened this issue 1 year ago • 1 comments

👓 What did you see?

There is an issue where formatting in documents written in Korean causes the keywords and sentences to have no space between them.

✅ What did you expect to see?

There should be a normal space between the formatted keywords and the sentences.

📦 Which tool/library version are you using?

Vs-code extension

image

🔬 How could we reproduce it?

  1. Write a document(.feature) in Korean. (With #language: ko)
  2. Trigger format.
  3. Observe that there is no space between the formatted keyword and the sentence.

📚 Any additional context?

Before formatting (What I exepected)

image

After formatting

image

Likilee avatar Jun 25 '24 08:06 Likilee

Thanks for flagging this @Likilee! This is an issue within the gherkin parser: a trailing space is missing on Korean step keywords. Thus, when the gherkin formatter parses your gherkin into a Cucumber messages format and writes back the changes, the step keywords and step text become joined.

Observe from the linked issue that I have raised a fix on the gherkin parser and we will have to await a release of the gherkin parser, cucumber language service and finally the Cucumber VSCode extension; but know that a fix is on its way!

kieran-ryan avatar Jul 04 '24 22:07 kieran-ryan