language-service icon indicating copy to clipboard operation
language-service copied to clipboard

support doc comments for php

Open nirajacharya2 opened this issue 5 months ago • 1 comments

🤔 What's changed?

Previously step definitions for function with doc comment didn't work. So, I've adjusted the regex to parse it correctly. Also other few changes:

  • updated the generated step definitions template for php
  • updated the test accordingly

⚡️ What's your motivation?

🏷️ What kind of change is this?

  • :book: Documentation (improvements without changing code)
  • :bank: Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)
  • :bug: Bug fix (non-breaking change which fixes a defect)
  • :zap: New feature (non-breaking change which adds new behaviour)
  • :boom: Breaking change (incompatible changes to the API)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • [x] I agree to respect and uphold the Cucumber Community Code of Conduct
  • [x] I've changed the behaviour of the code
    • [x] I have added/updated tests to cover my changes.
  • [ ] My change requires a change to the documentation.
    • [ ] I have updated the documentation accordingly.
  • [x] Users should know about my change
    • [x] I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

nirajacharya2 avatar Jul 25 '25 08:07 nirajacharya2

@luke-hill, @kieran-ryan can you please check this PR?

nirajacharya2 avatar Sep 23 '25 09:09 nirajacharya2