gherkin icon indicating copy to clipboard operation
gherkin copied to clipboard

French equivalent of `Given` is invariable

Open ecattez opened this issue 2 years ago • 12 comments

🤔 What's the problem you're trying to solve?

The equivalent of Given in French is invariable. It should be Etant donné or Etant donné que only.

✨ What's your proposed solution?

Remove all existing sentences, other than Etant donné and Etant donné que:

  • Etant donnée
  • Etant données
  • Etant donnés

⛏ Have you considered any alternatives or workarounds?

Let people write French like they want, but that would be direspectful for the language.


This text was originally generated from a template, then edited by hand. You can modify the template here.

ecattez avatar Sep 09 '22 09:09 ecattez

Cucumber JVM generates the annotations based on Gherkin. So I'm moving this to the common repo.

The translations can be found in:

https://github.com/cucumber/common/blob/main/gherkin/gherkin-languages.json#L1308

mpkorstanje avatar Sep 09 '22 09:09 mpkorstanje

@ecattez @fdelbrayelle how would you translate the following English step to French:

Given the following cars:
  | year | car                        |
  | 1936 | Bugatti Type 57SC Atlantic |
  | 1948 | Tucker Torpedo             |

I would write it like this:

Étant données les voitures suivantes:
  |  année | voiture                    |
  |   1936 | Bugatti Type 57SC Atlantic |
  |   1948 | Tucker Torpedo             |

I am not a native French speaker so I might have something to learn about grammar here...

aslakhellesoy avatar Sep 10 '22 20:09 aslakhellesoy

/cc @boucardbruno and @jbpros who added this translation here: https://github.com/cucumber-attic/gherkin2/compare/v2.5.1...v2.5.2

aslakhellesoy avatar Sep 10 '22 20:09 aslakhellesoy

Hello @aslakhellesoy.

It would be Étant donné les voitures suivantes. It's a particular thing of French grammar called '' preposition ''. If it was after the car, it would be Les voitures suivantes étant données.

You could find more info here : https://www.larousse.fr/dictionnaires/francais/%C3%A9tant_donn%C3%A9/31312

ecattez avatar Sep 10 '22 20:09 ecattez

Wow you learn something new every day. I’m all for removing the grammatically incorrect synonyms, but it would require a major release of Gherkin (and anything depending on it).

aslakhellesoy avatar Sep 10 '22 21:09 aslakhellesoy

I agree. Maybe we could deprecate all wrong synonyms before removing them?

ecattez avatar Sep 10 '22 21:09 ecattez

It’s deprecate :-). We don’t have a deprecation mechanism for keywords. Maybe we should make one…

aslakhellesoy avatar Sep 11 '22 07:09 aslakhellesoy

If it does not happen often, such a mechanism is not necessary, IMO

ecattez avatar Sep 11 '22 09:09 ecattez

@stof

ciaranmcnulty avatar Sep 11 '22 09:09 ciaranmcnulty

/cc @boucardbruno and @jbpros who added this translation here: cucumber-attic/[email protected]

Désolé! 🤓

I must say, now that I see it, I’m embarrassed I let that mistake go through!

jbpros avatar Sep 11 '22 10:09 jbpros

It happens. I'm French native and I discovered that rule few days ago. So we were wrong writing scenarios in team 😅

ecattez avatar Sep 11 '22 10:09 ecattez

I think 'people may write the scenario like this' is more important than grammatical purity though?

ciaranmcnulty avatar Sep 11 '22 11:09 ciaranmcnulty