gherkin icon indicating copy to clipboard operation
gherkin copied to clipboard

Feature keyword is marked as required but there is test data with features withoud keyword

Open elchupanebrej opened this issue 2 years ago • 1 comments

👓 What did you see?

I use jsonschema to generate code for messages and found that it couldn't work with https://github.com/cucumber/gherkin/blob/main/testdata/good/misc.feature.md.ast.ndjson

because Feature keyword is marked as required:

    "Feature": {
      "additionalProperties": false,
      "required": [
        "location",
        "tags",
        "language",
        "keyword",
        "name",
        "description",
        "children"
      ],

✅ What did you expect to see?

Make Feature keyword non-required or fix testdata

📦 Which tool/library version are you using?

Messages 22.0.0

📚 Any additional context?


This text was originally generated from a template, then edited by hand. You can modify the template here.

elchupanebrej avatar Jul 15 '23 04:07 elchupanebrej

I'm moving this to the Gherkin repo. Looks like the Markdown parser doesn't set the feature keyword when the .feature.md file doesn't use a feature header and uses the document title instead. I would consider this a bug in the parser.

mpkorstanje avatar Jul 15 '23 18:07 mpkorstanje