docs icon indicating copy to clipboard operation
docs copied to clipboard

Sidebar content overflows into next element

Open Krismix1 opened this issue 3 years ago • 6 comments

Describe the bug The content of the sidebar overflows. See attached picture.

To Reproduce Steps to reproduce the behaviour:

  1. Go to a page that has the sidebar + search input, e.g. https://cucumber.io/docs/gherkin/reference/
  2. Wait for the search input to load
  3. See error

Expected behaviour The content to not overflow.

Screenshots image

Desktop (please complete the following information):

  • OS: Linux
  • Browser: Firefox Developer Edition
  • Version: 95.0b12 (64-bit) I can also reproduce it in Chromium Version 96.0.4664.45 (Official Build) and Chrome Version 96.0.4664.45, both with an out-of-the-box setup.

Aditional context It would seem the initial height calculation does not take into account the height of the search input and it is not recalculated when the input loads. If the open or resize the browser devtools, or resize the browser window, the height of the scrollable content is adjusted and the issue is no longer visible.

Krismix1 avatar Dec 05 '21 14:12 Krismix1

Thanks for the report :)

aurelien-reeves avatar Dec 06 '21 07:12 aurelien-reeves

@declark this seems to be related to the smartbear stylesheet. Could you please take a look?

aurelien-reeves avatar Dec 06 '21 14:12 aurelien-reeves

@aurelien-reeves , I have found the same issue on Chrome - version 102.0.5005.61 (Official Build) (x86_64) on Mac OS - at https://cucumber.io/docs/guides/10-minute-tutorial/

side-nav-bar

I have found that inline css rule are injected by the following codes.

https://github.com/cucumber/docs/blob/2663a282125a9ec3bb9c7e21026d4d3a292bc8be/themes/cucumber-sb/static/js/cucumber-sb.min.js#L7827-L7829

Also, here is the screenshot of Chrome's dev-tool.

inline-css

I believe the above codes are the root cause of this issue. Please let me know what you think :)

10xtechie avatar Jun 15 '22 13:06 10xtechie

Thanks

Indeed, that looks related.

@declark do you know who at smartbear could help with this?

aurelien-reeves avatar Jun 15 '22 13:06 aurelien-reeves

@mattwynne Is there anyone at the Smartbear team that could pick this up?

mlvandijk avatar Jan 24 '23 07:01 mlvandijk

@mattwynne Is there anyone at the Smartbear team that could pick this up?

I've assigned it to Doug Clarke, and I will ping him in Slack too to make sure it's come to his attention.

mattwynne avatar Jan 24 '23 22:01 mattwynne