cucumber-js icon indicating copy to clipboard operation
cucumber-js copied to clipboard

Change Cucumber's own features to use cucumber-expressions (from regexes)

Open mattwynne opened this issue 3 years ago • 9 comments

Right now we're using regular expressions in our own step definitions.

It would be good to change these over to using cucumber expressions (and parameter types!) so that we're providing a good example of how Cucumber should be used.

mattwynne avatar Dec 10 '21 17:12 mattwynne

Agreed!

davidjgoss avatar Dec 10 '21 21:12 davidjgoss

If you're mobbing with new contributors on this - show them https://cucumber.github.io/cucumber-expressions/ !

aslakhellesoy avatar Dec 17 '21 00:12 aslakhellesoy

Hi @mattwynne, I would like to contribute to this issue.

ghost avatar Feb 18 '22 18:02 ghost

Awesome @shvmsnju, let me know if you need any help.

mattwynne avatar Feb 18 '22 21:02 mattwynne

Is this issues still valid/pending? I could have a look to get started with the code base.

pk avatar Jun 08 '23 14:06 pk

@pk absolutely, feel free to raise PRs and let me know if you need any pointers.

davidjgoss avatar Jun 10 '23 11:06 davidjgoss

Perfect, we are using Cucumber so much that we really would like to contribute. Also our test suites are getting more and more complex and we may need to start to use some features from API, running the Features dynamically so it would be nice to contribute before I start asking too many questions. ;)

pk avatar Jun 12 '23 07:06 pk

OK, I've looked into this and I think this task is done.

There are steps under compability/**/*.ts and features/step_definitions/*.ts all of which has been converted into the Cucumber Expressions.

I've done search for Given/When/Then with the RegExp patterns and it really yields references to the steps with RegExp only in *.md files.

I may be missing something....

pk avatar Jun 12 '23 21:06 pk

Sorry for the confusion @pk - updating the examples in the .md docs would be equally valuable though!

davidjgoss avatar Jun 14 '23 12:06 davidjgoss