cucumber
fix flaky QtTestDriver test
Summary
The test output contained timing information, leading to a flaky test. Fixed by using the TAP output, that doesn't contain timing information.
Details
See https://doc.qt.io/qt-6/qtest-overview.html#logging-options for more information.
Motivation and Context
Solves the issue from this PR: https://github.com/cucumber/cucumber-cpp/pull/293#issuecomment-2049850379
How Has This Been Tested?
The fix itself is only manually verified. The code has automated tests, hence pretty sure to not have added a regression.
Note: the log output changed, but it should only affect developers reading the log.
Types of changes
- [x] Bug fix (non-breaking change which fixes an issue).
- [ ] New feature (non-breaking change which adds functionality).
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).
Checklist:
- [x] It is my own work, its copyright is implicitly assigned to the project and no substantial part of it has been copied from other sources (including Stack Overflow). In rare occasions this is acceptable, like in CMake modules where the original copyright information should be kept.
- [x] I'm using the same code standards as the existing code (indentation, spacing, variable naming, ...).
- [ ] I've added tests for my code.
- [x] I have verified whether my change requires changes to the documentation
- [x] My change either requires no documentation change or I've updated the documentation accordingly.
- [x] My branch has been rebased to main, keeping only relevant commits.
@kreuzberger please have a look. Would be happy to get feedback if this fixes the flaky tests you encountered.
@kreuzberger please have a look. Would be happy to get feedback if this fixes the flaky tests you encountered.
as the tap format does not contain timing informations, yes this would fix it. :+1:
