common
common copied to clipboard
cucumber
Build gherkin/dart
The new gherkin/dart module is not built in CI.
When https://github.com/cucumber/common/pull/1630 was merged we forgot to add a job to .circleci/config.yml, so it isn't built as a separate job. There is nothing in gherkin/Makefile either, so the module isn't built as part of the serial job either.
/cc @mattwynne @aurelien-reeves
Oops. I figured the fact that the CI was failing before we added Dart to the build image meant it was being tested in CI. I should have looked closer.
@lamkr are you interested in helping with this? It would be good to see how easy the CI / Make infrastructure is to understand for someone new to it.
Oops. I figured the fact that the CI was failing before we added Dart to the build image meant it was being tested in CI. I should have looked closer.
@lamkr are you interested in helping with this? It would be good to see how easy the CI / Make infrastructure is to understand for someone new to it.
hi, @mattwynne ! I don't have that much time available but I will do my best to help. I'm not an expert in CI either, but where can I start?
@lamkr I think the place to start is to add a gherkin/dart/Makefile with a default target that compiles and tests the code. Then we can integrate that into the main gherkin/Makefile and finally add a job to CI to run it.
@ciaranmcnulty it strikes me this could present a good opportunity to try our ideas about breaking up the Docker image monolith, since the Makefile here is essentially green field?
I've realised that the dart command wasn't even in the PATH in the build image, because I hadn't tested the installation script properly. I'll release a new version of the build image soon.
See https://github.com/cucumber/build/pull/53