cubing.js icon indicating copy to clipboard operation
cubing.js copied to clipboard

Disconnect 3D puzzles from listeners as soon as the player puzzle changes.

Open lgarron opened this issue 4 years ago • 0 comments

To Reproduce Steps to reproduce the behavior:

  1. Go to https://alpha.twizzle.net/explore/?alg=%28U+F+R+D+B+L%29&puzzle=30x30x30
  2. Change the puzzle to 40x40x40lgarr

The 30x30x30 puzzle flashes a significantly more scrambled state, probably from reading a 40x40x40 state. 24567 @5 89

Expected behavior The puzzle changes immediately, or at least doesn't show an inconsistent state.

I think this disconnection isn't doing its job: https://github.com/cubing/cubing.js/blob/f856f0fba82c53d60182c98484a661ea59d74cf7/src/cubing/twisty/views/3D/Twisty3DSceneWrapper.ts#L176

lgarron avatar Jan 07 '22 05:01 lgarron