cubefs icon indicating copy to clipboard operation
cubefs copied to clipboard

chore(metanode): only delete the metrics of volumes that no longer exist on the metanode

Open daimashusheng opened this issue 4 months ago • 1 comments


e deleted to avoid broken lines in Grafana

Motivation

If we delete the metrics of volumes that still exist on the metanode, Grafana may show broken lines in the charts.

Modifications

We only delete the metrics of volumes that no longer exist on the metanode.

Types of changes

  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] Documentation Update (if none of the other choices apply)
  • [x] So on...

Verifying this change

  • [x] Make sure that the change passes the testing checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • [ ] Master
  • [x] MetaNode
  • [ ] DataNode
  • [ ] ObjectNode
  • [ ] AuthNode
  • [ ] LcNode
  • [ ] Blobstore
  • [ ] Client
  • [ ] Cli
  • [ ] SDK
  • [ ] Other Tools
  • [ ] Common Packages
  • [ ] Dependencies
  • [ ] Anything that affects deployment

Documentation

  • [ ] doc
  • [ ] doc-required
  • [ ] doc-not-needed
  • [ ] doc-complete

Review Expection

  • [ ] in-two-days
  • [ ] weekly
  • [ ] free-time
  • [ ] whenever

Matching PR in forked repository

PR in forked repository:

daimashusheng avatar Nov 20 '25 12:11 daimashusheng

Deploy Preview for cubefs-check ready!

Name Link
Latest commit ab5a0fc6ba9c624157f488502caa97f04600af02
Latest deploy log https://app.netlify.com/projects/cubefs-check/deploys/6940fcc739610f0008e27248
Deploy Preview https://deploy-preview-3967--cubefs-check.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Nov 20 '25 12:11 netlify[bot]

Codecov Report

:x: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 23.14%. Comparing base (8960fc7) to head (ab5a0fc). :warning: Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
metanode/metrics.go 0.00% 17 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3967       +/-   ##
===========================================
- Coverage   56.83%   23.14%   -33.69%     
===========================================
  Files         431      386       -45     
  Lines       88835   130172    +41337     
===========================================
- Hits        50491    30131    -20360     
- Misses      34731    96348    +61617     
- Partials     3613     3693       +80     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 16 '25 06:12 codecov[bot]