feat(server): Add server config for headers and keep alive timeouts
Check List
- [x] Tests have been run in packages where changes made if available
- [x] Linter has been run for changed code
- [x] Docs have been added / updated if required
- [ ] Tests for the changes have been added if not covered yet
Description of Changes Made
This is a change that we've been using in our application to sync the timeouts with the LoadBalancer correctly.
Added two new environment variables to configure HTTP server options:
CUBEJS_SERVER_HEADERS_TIMEOUTCUBEJS_SERVER_KEEP_ALIVE_TIMEOUT
Each default to the default values in the Server class found in the HTTP Node module.
Hi @KSDaemon! Do you think this feature could be added anytime soon? Do you see any utility? We're actually using it productively ;)
Hey @marianore-muttdata looks good. Could you please rebase it on top of the latest master branch? GitHub shows that there are some conflicts. Thnx!
Hey @marianore-muttdata! Actually... The tests are failing because of:
Error: Invalid cube-server-core options: "serverHeadersTimeout" is not
allowed. "serverKeepAliveTimeout" is not allowed
We forgot to update the options scheme here
Hey @marianore-muttdata! Actually... The tests are failing because of:
Error: Invalid cube-server-core options: "serverHeadersTimeout" is not allowed. "serverKeepAliveTimeout" is not allowedWe forgot to update the options scheme here
Got it! Let me know if there's anything else that you'd write differently.
I think now everything is fine! :) Let's merge!