cube
cube copied to clipboard
cube-js
Deprecate request promise
Check List
- [x] Tests has been run in packages where changes made if available
- [x] Linter has been run for changed code
- [x] Tests for the changes have been added if not covered yet
- [x] Docs have been added / updated if required
Issue Reference this PR resolves Resolves #8204
Description of Changes Made (if issue reference is not provided)
The request and request-promise packages were removed in favor of rock-req (https://github.com/carboneio/rock-req). This aims to resolve dependence on deprecated packages and the vulnerabilities associated with them. However, this has not attempted to remove the offending packages from devDependencies (i.e., in the schema compiler).
Note: I'm not convinced the unit testing strategy is sufficient to prove that these changes haven't broken anything because unit tests typically mock the rock-req package. Will attempt to test locally with an active cube.js instance.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| examples-angular-dashboard | ⬜️ Ignored (Inspect) | Visit Preview | May 21, 2024 3:33pm | |
| examples-react-d3 | ⬜️ Ignored (Inspect) | Visit Preview | May 21, 2024 3:33pm | |
| examples-react-dashboard | ⬜️ Ignored (Inspect) | Visit Preview | May 21, 2024 3:33pm | |
| examples-react-data-table | ⬜️ Ignored (Inspect) | Visit Preview | May 21, 2024 3:33pm | |
| examples-react-highcharts | ⬜️ Ignored (Inspect) | Visit Preview | May 21, 2024 3:33pm | |
| examples-react-material-ui | ⬜️ Ignored (Inspect) | Visit Preview | May 21, 2024 3:33pm | |
| examples-react-pivot-table | ⬜️ Ignored (Inspect) | Visit Preview | May 21, 2024 3:33pm | |
| examples-vue-query-builder | ⬜️ Ignored (Inspect) | Visit Preview | May 21, 2024 3:33pm |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
@jlloyd-widen Thanks for contributing to this one! I'd suggest we go with node-fetch as it's already in dependencies. Sorry for not mentioning it earlier.
@paveltiunov Thanks for the guidance. I have updated the PR to use node-fetch. I'm a newbie at typescript so I encourage a pretty thorough code review to make sure everything looks like it's up to best practice.