cube icon indicating copy to clipboard operation
cube copied to clipboard

Facilitate comments in GraphQL schema generation flow

Open tsilvasstk opened this issue 2 years ago • 3 comments

Is your feature request related to a problem? Please describe. The GraphQL schema that is generated has no comments/documentation. It does not suit inclusion into a well documented federated graph.

Describe the solution you'd like A way to annotate dimensions such that the generated GraphQL types have some degree of documentation.

Describe alternatives you've considered Manual documentation post-generation. It does not suit our needs as we scale up

tsilvasstk avatar Mar 06 '23 09:03 tsilvasstk

@tsilvasstk I guess we can use the description to generate comments. Thanks for posting it! Please let us know if you want to work on this!

paveltiunov avatar Mar 16 '23 04:03 paveltiunov

If you are interested in working on this issue, please leave a comment below and we will be happy to assign the issue to you. If this is the first time you are contributing a Pull Request to Cube.js, please check our contribution guidelines. You can also post any questions while contributing in the #contributors channel in the Cube.js Slack.

github-actions[bot] avatar Mar 16 '23 04:03 github-actions[bot]

It looks like this might require a fairly tiny change to this part of code: https://github.com/cube-js/cube/blob/master/packages/cubejs-api-gateway/src/graphql.ts#L378-L398

igorlukanin avatar Feb 01 '24 14:02 igorlukanin