cube
cube copied to clipboard
feat(client-core): Add loadResponse and loadResponses to ResultSet
The loadResponse(s) that are set on the ResultSet allow determining some useful metadata on a query. These attributes should be included in the typing so that users writing in Typescript can access their information without running into errors from the missing attributes.
Check List
- [x] Tests has been run in packages where changes made if available
- [x] Linter has been run for changed code
- [x] Tests for the changes have been added if not covered yet
- [x] Docs have been added / updated if required
Codecov Report
Merging #5081 (ef3756c) into master (06b6476) will decrease coverage by
13.79%. The diff coverage isn/a.
@@ Coverage Diff @@
## master #5081 +/- ##
===========================================
- Coverage 74.02% 60.23% -13.80%
===========================================
Files 266 139 -127
Lines 30559 11487 -19072
Branches 2803 2803
===========================================
- Hits 22621 6919 -15702
+ Misses 7638 4277 -3361
+ Partials 300 291 -9
| Flag | Coverage Ξ | |
|---|---|---|
| cube-backend | 60.23% <ΓΈ> (+0.44%) |
:arrow_up: |
| cubesql | ? |
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
hi @tchell! We didn't expose it intentionally as it's not a part of public API. Though you can still use the serialize method
Understood. That is not super obvious in the documentation.