cube
cube copied to clipboard
Changes need for elasticsearch v7 compatibility
A PR for elasticsearchdriver compatibility since the authors of the code have not made a PR pull request.
Check List
- [ ] Tests has been run in packages where changes made if available
- [ ] Linter has been run for changed code
- [ ] Tests for the changes have been added if not covered yet
- [ ] Docs have been added / updated if required
Issue Reference this PR resolves
[https://github.com/cube-js/cube.js/issues/3520]
Description of Changes Made (if issue reference is not provided)
[Description goes here]
Thanks for contributing it, @paularmand! Would you mind adding E2E test for that? Questdb or Firebolt driver tests in cubejs-testing
directory would be a great start for that.
Codecov Report
Merging #5023 (eb6a83d) into master (52877ac) will decrease coverage by
22.49%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #5023 +/- ##
===========================================
- Coverage 82.27% 59.77% -22.50%
===========================================
Files 126 138 +12
Lines 18861 11443 -7418
Branches 0 2791 +2791
===========================================
- Hits 15517 6840 -8677
- Misses 3344 4304 +960
- Partials 0 299 +299
Flag | Coverage Ξ | |
---|---|---|
cube-backend | 59.77% <ΓΈ> (?) |
|
cubesql | ? |
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.