cube icon indicating copy to clipboard operation
cube copied to clipboard

Changes need for elasticsearch v7 compatibility

Open paularmand opened this issue 2 years ago β€’ 0 comments

A PR for elasticsearchdriver compatibility since the authors of the code have not made a PR pull request.

Check List

  • [ ] Tests has been run in packages where changes made if available
  • [ ] Linter has been run for changed code
  • [ ] Tests for the changes have been added if not covered yet
  • [ ] Docs have been added / updated if required

Issue Reference this PR resolves

[https://github.com/cube-js/cube.js/issues/3520]

Description of Changes Made (if issue reference is not provided)

[Description goes here]

paularmand avatar Jul 29 '22 08:07 paularmand

Thanks for contributing it, @paularmand! Would you mind adding E2E test for that? Questdb or Firebolt driver tests in cubejs-testing directory would be a great start for that.

paveltiunov avatar Aug 15 '22 06:08 paveltiunov

Codecov Report

Merging #5023 (eb6a83d) into master (52877ac) will decrease coverage by 22.49%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #5023       +/-   ##
===========================================
- Coverage   82.27%   59.77%   -22.50%     
===========================================
  Files         126      138       +12     
  Lines       18861    11443     -7418     
  Branches        0     2791     +2791     
===========================================
- Hits        15517     6840     -8677     
- Misses       3344     4304      +960     
- Partials        0      299      +299     
Flag Coverage Ξ”
cube-backend 59.77% <ΓΈ> (?)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
rust/cubesql/pg-srv/src/pg_type.rs
rust/cubesql/cubesql/src/compile/engine/df/scan.rs
...ompile/engine/information_schema/postgres/pg_am.rs
.../compile/engine/information_schema/postgres/ext.rs
rust/cubesql/cubesql/src/config/mod.rs
...sql/cubeclient/src/models/v1_load_request_query.rs
...t/cubesql/cubesql/src/compile/rewrite/converter.rs
...sql/src/compile/engine/information_schema/utils.rs
...mpile/engine/information_schema/postgres/tables.rs
...le/engine/information_schema/postgres/pg_tables.rs
... and 254 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 15 '22 07:08 codecov[bot]