cube icon indicating copy to clipboard operation
cube copied to clipboard

feat(cubestore): Aggregating index in pre-aggregations

Open waralexrom opened this issue 1 year ago • 1 comments

Check List

  • [ ] Tests has been run in packages where changes made if available
  • [ ] Linter has been run for changed code
  • [ ] Tests for the changes have been added if not covered yet
  • [ ] Docs have been added / updated if required

Description of Changes Made (if issue reference is not provided)

Added the type field to the index description in the schema. This field can have two values - regular (default) and aggregate. I also added the corresponding changes to the CREATE TABLE queries.

waralexrom avatar Jul 28 '22 10:07 waralexrom

Codecov Report

Merging #5016 (cb91f1c) into master (19e7a71) will decrease coverage by 22.96%. The diff coverage is 45.16%.

@@             Coverage Diff             @@
##           master    #5016       +/-   ##
===========================================
- Coverage   82.99%   60.02%   -22.97%     
===========================================
  Files         129      139       +10     
  Lines       19607    11593     -8014     
  Branches        0     2918     +2918     
===========================================
- Hits        16272     6959     -9313     
- Misses       3335     4130      +795     
- Partials        0      504      +504     
Flag Coverage Δ
cube-backend 60.02% <45.16%> (?)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...cubejs-query-orchestrator/src/driver/BaseDriver.js 26.06% <0.00%> (ø)
...bejs-schema-compiler/src/compiler/CubeEvaluator.js 72.00% <ø> (ø)
...bejs-schema-compiler/src/compiler/CubeValidator.js 97.52% <ø> (ø)
...cubejs-schema-compiler/src/compiler/CubeSymbols.js 90.20% <16.66%> (ø)
...y-orchestrator/src/orchestrator/PreAggregations.ts 79.30% <50.00%> (ø)
...ejs-schema-compiler/src/adapter/PreAggregations.js 59.26% <55.55%> (ø)
rust/cubesql/cubesql/src/transport/ext.rs
...mpile/engine/information_schema/postgres/tables.rs
...ql/src/sql/database_variables/mysql/global_vars.rs
rust/cubesql/cubesql/src/sql/types.rs
... and 264 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Jul 28 '22 11:07 codecov[bot]