cube
cube copied to clipboard
MSSQL compiler fix
Check List
- [ ] Tests has been run in packages where changes made if available
- [ ] Linter has been run for changed code
- [ ] Tests for the changes have been added if not covered yet
- [ ] Docs have been added / updated if required
Issue Reference this PR resolves
Resolved #573
Description of Changes Made (if issue reference is not provided)
Alternate fix for PR #2693
Codecov Report
Merging #4975 (ee076f7) into master (a10bd59) will increase coverage by
0.03%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## master #4975 +/- ##
==========================================
+ Coverage 59.77% 59.81% +0.03%
==========================================
Files 124 138 +14
Lines 9946 11421 +1475
Branches 2253 2778 +525
==========================================
+ Hits 5945 6831 +886
- Misses 3719 4290 +571
- Partials 282 300 +18
Flag | Coverage Ξ | |
---|---|---|
cube-backend | 59.81% <0.00%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Ξ | |
---|---|---|
...es/cubejs-schema-compiler/src/adapter/BaseQuery.js | 64.72% <0.00%> (+0.71%) |
:arrow_up: |
...s/cubejs-schema-compiler/src/adapter/MssqlQuery.js | 57.50% <0.00%> (-3.32%) |
:arrow_down: |
...ages/cubejs-query-orchestrator/src/driver/utils.ts | 58.82% <0.00%> (-41.18%) |
:arrow_down: |
...hema-compiler/src/extensions/extension.abstract.ts | 66.66% <0.00%> (-33.34%) |
:arrow_down: |
packages/cubejs-backend-shared/src/env.ts | 31.31% <0.00%> (-7.31%) |
:arrow_down: |
...orchestrator/src/orchestrator/QueryOrchestrator.ts | 60.00% <0.00%> (-4.29%) |
:arrow_down: |
...hestrator/src/orchestrator/StreamObjectsCounter.ts | 26.66% <0.00%> (-4.11%) |
:arrow_down: |
...src/compiler/transpilers/ImportExportTranspiler.ts | 34.48% <0.00%> (-3.98%) |
:arrow_down: |
...s/cubejs-schema-compiler/src/adapter/BaseFilter.js | 54.64% <0.00%> (-2.83%) |
:arrow_down: |
...y-orchestrator/src/orchestrator/PreAggregations.ts | 81.23% <0.00%> (-2.77%) |
:arrow_down: |
... and 76 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact)
,ΓΈ = not affected
,? = missing data
Powered by Codecov. Last update a10bd59...ee076f7. Read the comment docs.
@ovr @paveltiunov π
Hi, @davefrancis. I'm closing this PR as I've rewritten it in https://github.com/cube-js/cube.js/pull/5078.
Awesome! Thanks @buntarb.