cube icon indicating copy to clipboard operation
cube copied to clipboard

feat: query - allow booleans in values, fix #1723

Open ovr opened this issue 3 years ago • 2 comments

Hello!

refs https://github.com/cube-js/cube.js/issues/1723

Thanks

ovr avatar Jan 05 '21 16:01 ovr

Hi @ovr, do you know when this is planned to be merged? I came across #1723 and we've had to implement the numbers as strings to represent booleans "fix" to get around it i.e. '1' = true '0' = false

Cheers

benswinburne avatar Jun 07 '21 16:06 benswinburne

Hi guys, I'm implementing a new cube server and still coming across this issue, any update please?

pierre-b avatar Jul 18 '22 20:07 pierre-b

Codecov Report

Patch and project coverage have no change.

Comparison is base (aea2daf) 47.05% compared to head (818ffbd) 47.05%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1727   +/-   ##
=======================================
  Coverage   47.05%   47.05%           
=======================================
  Files         153      153           
  Lines       20279    20279           
  Branches     5197     5197           
=======================================
  Hits         9543     9543           
  Misses       9898     9898           
  Partials      838      838           
Flag Coverage Δ
cube-backend 47.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/cubejs-api-gateway/src/query.js 76.47% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Apr 14 '23 14:04 codecov[bot]