django-admin-view-permission
django-admin-view-permission copied to clipboard
View permissions into core ?
Hi !
There's an ongoing PR to include view permissions into django core : https://github.com/django/django/pull/6734/
I just found out about your work here, and since it really aims to do the same thing, I thought you may be interested ?
Bests,
Olivier
Very, very nice, I really like this project, because it frees my hands from using patched Django version, which I did for a really long time.
Is the code of this based on my initial commits, or is it stand alone work?
Hi @PetrDlouhy,
It's a stand alone work. I saw your commit and I've noticed your commit (https://github.com/django/django/pull/6734/commits/184f41609c3137d7703bff23e1d2d82c4c5a9460) and from what I saw, the two implementations share common features :+1:
The feature is integrated into core starting on django 2.1.
The readme should be changed accordingly to this change. It should inform, that this is useful only for compatibility in older projects and it should contain migration instructions.
My tests just started to fail with some duplicate key value violates unique constraint "auth_permission_content....
. Removing admin_view_permission
from settings.py solved it.
There should be some writings about the django 2.1 release about this in this readme. I think commenting out the app like I did is the only thing you need to do when upgrading to 2.1.