react-tabtab
react-tabtab copied to clipboard
Fix #130 and #114 -- removing tabs error
Fix #130 and #114 as they stem from the same issue of index checking elements that are out of bounds. This fix will prevent crashes when closing tabs and modals.
Codecov Report
Merging #131 into master will decrease coverage by
0.44%
. The diff coverage is50%
.
@@ Coverage Diff @@
## master #131 +/- ##
==========================================
- Coverage 87.27% 86.82% -0.45%
==========================================
Files 20 20
Lines 330 334 +4
Branches 63 65 +2
==========================================
+ Hits 288 290 +2
- Misses 34 36 +2
Partials 8 8
Impacted Files | Coverage Δ | |
---|---|---|
src/TabList.js | 75.93% <50%> (-0.81%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d85c192...15db15f. Read the comment docs.
Hey @stefanuros! Thanks for the contribution! Would you mind add a test case here as well?
Since it's been almost a year, seems like this isn't going to be updated. Can we merge the change in without the test case?
Looks like @stefanuros had abandoned it. I tried to create some tests here but no success yet. Someone had progress? @anjalikk14 did you accomplished something?
Could you (@ctxhou) give me some clue in how to approach it?