react-universally icon indicating copy to clipboard operation
react-universally copied to clipboard

Use mini-css-extract instead of extract-text-plugin

Open diondirza opened this issue 6 years ago • 2 comments

Using mini-css-extract plugin improve our page load time, since css will be trimmed per view usage, instead of load big chunk unused style in single css file its better to have css loaded on demand, based on page view

diondirza avatar Mar 17 '18 07:03 diondirza

I think this is a great idea as long as it can support having a global css and css modules. I'm assuming if you put an import in a top level component (and don't use css modules in webpack) that would solve the global problem. Will this just work out of the box with import() and react-async-component? How cool.

unleashit avatar Mar 17 '18 21:03 unleashit

@diondirza @unleashit how is this working out for you so far? Good to merge or are there known issues?

oyeanuj avatar Jul 28 '18 23:07 oyeanuj