react-universally icon indicating copy to clipboard operation
react-universally copied to clipboard

Published 20 hours ago • verified publisher icon ctrlplusb

Release: Version 14

Open strues opened this issue 7 years ago • 12 comments

I haven't seen any check lists going around or a discussion on releasing the next branch so here we are.

  • [ ] Merge master bug fix pending PRs
  • [ ] Merge master changed into Next
  • [ ] Test Next
  • [x] RenderToNodeStream?

What else am I forgetting? We should get this up to date and out since the release of React 16 seems to be smooth.

strues avatar Oct 11 '17 18:10 strues

Yes! We should also go through the ideas/suggestions for 'next' ticket and see which of those can be included: https://github.com/ctrlplusb/react-universally/issues/428

oyeanuj avatar Oct 11 '17 20:10 oyeanuj

Hey all! Thanks for the activity here.

Please would all contributors get active on the gitter channel. Thanks 👍

I'd like us to start using a git rebase strategy for next and all pull requests in order to keep the merge noise down. If you are unfamiliar with git rebasing then please let me know and I would be happy to take you through it. 👍

Please keep all changes targetting next rather than master. I know we have already let a few slip into master but moving forward it would be best to use next to stage up some changes before me merge in.

I'll review #428 and give some more of my ideas.

Also, has anyone tried react-loadable against this project? James has added some cool APIs such as the preloadAll. It may be worth trying a branch out and seeing how it flies.

I'd also like to start killing the feature branches. Really keep them down to 2 or 3 at an absolute maximum. I know we had an issue for this already. I'll revisit it soon.

ctrlplusb avatar Oct 16 '17 12:10 ctrlplusb

How does this work with css-in-js libraries, e.g. styled-components? Will this be a problem for branches?

codepunkt avatar Oct 17 '17 18:10 codepunkt

@ctrlplusb which branches you think will be good to maintain?

sergiokopplin avatar Oct 23 '17 21:10 sergiokopplin

@codepunkt you mean 'RenderToNodeStream' with css-in-js?

sergiokopplin avatar Oct 23 '17 21:10 sergiokopplin

@sergiokopplin Yeah. Just noticed i've commented into the wrong issue. Sorry for that!

codepunkt avatar Oct 24 '17 06:10 codepunkt

Another topic for v14:

https://github.com/ctrlplusb/react-universally/blob/83d533a9c780716d18f034f7fb52dbd3a1c4051b/internal/webpack/configFactory.js#L379-L383

I noticed in the configFactory here that we create client bundles in ES5. I was researching a little bit more and it seems like if we set up two bundles - one for modern browsers and one for non-modern browsers, we can make a significant dent on bundle sizes.

Still new to this topic but most of my understanding comes from this article: https://philipwalton.com/articles/deploying-es2015-code-in-production-today/

#514 and #531 seem to also be related to this.

oyeanuj avatar Oct 29 '17 21:10 oyeanuj

I've been busy in React Native world, please let me know if you guys need help. It's my favourite project so I'm looking forward to see in what direction we're going.

birkir avatar Nov 02 '17 18:11 birkir

Hello, Any updates on next version?

Best

saniko avatar Mar 04 '18 14:03 saniko

next now has both webpack 4 and react 16

https://github.com/ctrlplusb/react-universally/compare/master...next

Question @ctrlplusb , are we using prettier-eslint or no? There seems to be an inconsistency between branches regarding prettier. All pull-requests are now including prettier junk, making it very hard to glance PR's.

Thanks

birkir avatar Mar 13 '18 16:03 birkir

I am keen on vanilla prettier (i.e. without the prettier-eslint). We should also use eslint-preset-prettier alongside eslint-preset-airbnb in order to disable all the style rules. 👍

ctrlplusb avatar Mar 14 '18 20:03 ctrlplusb

@birkir Thoughts on https://github.com/ctrlplusb/react-universally/issues/524#issuecomment-340304381 with webpack 4?

oyeanuj avatar Mar 17 '18 16:03 oyeanuj