react-tree-walker icon indicating copy to clipboard operation
react-tree-walker copied to clipboard

Published 20 hours ago • verified publisher icon ctrlplusb

Warning: Rendering <Context.Consumer.Provider> is not supported and will be removed in a future major release.

Open dobesv opened this issue 6 years ago • 3 comments

The current version 4.3.0 of react-tree-walker in npm triggers this warning on Context components.

Looking at the repository, this might be fixed in master but I can't tell for sure until a new version is released.

dobesv avatar Jan 08 '19 21:01 dobesv

I've been able to workaround this warning (and errors getting thrown from libraries like react-helmet-async) by installing this library from GitHub directly.

This works fine with Yarn but for some reason NPM doesn't want to install all the files on the master branch so I'm still stuck getting this library to work with the new context api because I need to support both Yarn and NPM.

At least its progress of some sort but @ctrlplusb publishing the new version is obviously the correct fix here.

ghost avatar Mar 04 '19 16:03 ghost

bump.. when will the fix in the master be released as a new version on npm? @ctrlplusb

flyon avatar Sep 12 '19 11:09 flyon

Hey there,

I was the original poster of the above ghost message and have a bit of an update.

Got things working and if you need a quick fix for now its pretty simple npm install promotively/react-tree-walker or yarn add promotively/react-tree-walker.

We also tried using react-ssr-prepass but had several issues with it (Haven't used it for a while now so its possible that its far more suitable for production than it was, but at the bottom of the readme it still says its not intended for production usage which makes me think otherwise.

I have since migrated our data fetching library package @promotively/react-redux-data towards using the Provider pattern that other libraries such as react-helmet-async use. This is still a solid solution to the problem at hand and is not going to break in future react releases (with the downside of a double render but that's not really a big deal if you are caching SSR pages as you should be anyway)

As far as actual proper suspense support for SSR is concerned - https://github.com/facebook/react/issues/13206 (Doesn't look like its arriving anytime soon)

stevenewing avatar Sep 12 '19 14:09 stevenewing