react-component-queries icon indicating copy to clipboard operation
react-component-queries copied to clipboard
verified publisher icon ctrlplusb

monitorPosition passthrough

Open bradennapier opened this issue 8 years ago • 2 comments

Added ability to specify monitorPosition as well.

bradennapier avatar May 03 '17 00:05 bradennapier

Hey @bradennapier

Thanks for taking this on. I am happy with the monitorPosition changes but I am wondering about your motivation for the sizePassThrough prop?

ctrlplusb avatar May 11 '17 10:05 ctrlplusb

And... I have just read your first PR notes. Hmmm interesting case. I wonder if this should be considered on react-sizeme.

I would like to take some time to consider this separately. Ideally I think if you are using react-component-queries you shouldn't have the size get passed down to the WrappedComponent anyways. It should only be handled by the responsive functions.

Do you mind removing the concept of size pass through from this PR so we can merge the rest? We can continue the discussion then on the other PR you opened.

ctrlplusb avatar May 11 '17 10:05 ctrlplusb