easy-peasy icon indicating copy to clipboard operation
easy-peasy copied to clipboard

Published 20 hours ago • verified publisher icon ctrlplusb

Community feedback on `unstable_effectOn`

Open ctrlplusb opened this issue 1 year ago • 2 comments

I'd like to consider moving this API to stable pending feedback from the community.

Also looking to incorporate the work in PR #598

ctrlplusb avatar Sep 15 '22 14:09 ctrlplusb

Haven't seen this one. What is the usecase for this, over ActionOn and ThunkOn?

jmyrland avatar Sep 15 '22 16:09 jmyrland

Hi,

we used the effectOn for serval months and it worked perfect and was very useful. But a a refactoring of our store, we could not use effectOn due to missing PR #598 It would be great if the PR will be merged and effectOn gets moved to stable.

rainerbruemmer avatar Sep 16 '22 09:09 rainerbruemmer

Haven't seen this one. What is the usecase for this, over ActionOn and ThunkOn?

It allows you to track state rather than actions. Which can help avoid cases of having to track multiple actions in the case of ActionOn and ThunkOn.

ctrlplusb avatar Sep 16 '22 13:09 ctrlplusb

Is #597 & #596 still an issue?

jmyrland avatar Sep 16 '22 18:09 jmyrland

I think after merging #598 and fixing #597 separately, it will be stable. I didn't notice any other problems than those two and the api itself is really useful. Thanks @ctrlplusb for finding time for this!

methyl avatar Sep 29 '22 13:09 methyl

Hey, I use unstable_effectOn in one of my projects, and it's working great! The only downside with it, is it can only track up to 6 states in the store. I've managed to find some workarounds, but it would be great if it could listen to as many states as we want, similar to how thunkOn can listen to unlimited actions.

Thank you so much for maintaining easy-peasy!

tormodAase avatar Sep 29 '22 15:09 tormodAase

Nice one. Yeah, we can look into that quality of life improvement too. 👍

ctrlplusb avatar Oct 25 '22 13:10 ctrlplusb

@tormodAase

The only downside with it, is it can only track up to 6 states in the store. I've managed to find some workarounds, but it would be great if it could listen to as many states as we want, similar to how thunkOn can listen to unlimited actions.

I think this a typescript-only limitation and should be a matter of just updating a few types (namely this type type, which imposes a limitation of six state resolvers on both the unstable_effectOn and computed functions, this type, and also this type if we want to address this for computed props as well).

I can open a PR for this if you'd like @ctrlplusb.

no-stack-dub-sack avatar Oct 26 '22 17:10 no-stack-dub-sack

The only downside with it, is it can only track up to 6 states in the store.

This is fixed by #787 👍

jmyrland avatar Nov 02 '22 06:11 jmyrland

@jmyrland and @no-stack-dub-sack on fire. 🔥😎

ctrlplusb avatar Nov 23 '22 03:11 ctrlplusb

I think after merging #598 and fixing #597 separately, it will be stable. I didn't notice any other problems than those two and the api itself is really useful. Thanks @ctrlplusb for finding time for this!

With #598 merged and #597 fixed by #812, I think we're in pretty good shape here. There are no other open issues related to unstable_effectOn and no comments in this thread that suggest its not ready to be made stable.

What do you think @ctrlplusb, @jmyrland?

no-stack-dub-sack avatar Jan 18 '23 15:01 no-stack-dub-sack

With #598 merged and #597 fixed by #812, I think we're in pretty good shape here. There are no other open issues related to unstable_effectOn and no comments in this thread that suggest its not ready to be made stable.

What do you think @ctrlplusb, @jmyrland?

I think we're ready for a release soon! 🚀

jmyrland avatar Jan 18 '23 17:01 jmyrland