ctrlc03

Results 41 comments of ctrlc03

> Hey @ctrlc03, just checking in. We updated the Ownable library, so it's no longer a blocker. No pressure, but did you want to continue working on this? Let us...

> Hey, @ctrlc03! Just checking in. Were you able to make any headway on this PR? Again, no pressure! Let us know if you're too busy. We can take over...

> > My apologies, been crazy busy lately. Finishing up now - writing up the tests hoping that they finally work on my setup :) > > No worries! And...

> Good luck, let me know how it goes! I somehow made it! lost the past commits but I think that's fine. The code works and so do tests. I've...

> > ...I will say that I don't mind if this functionality is added by default in Ownable. It gives the user of Ownable a choice to use either one-step...

Hi Andrew, Git noob here, I have made all changes locally in a separate branch as I couldn’t pull from main, however, what’s the best way to submit the new...

> Hey, @ctrlc03! > > So when there's conflicts in a PR, it's a good idea to checkout that branch, `git merge`, and fix the conflicts. It might make sense...

Decided to wait until v1.0

> Question: what does the topup feature designed at the very beginning? like under what kind of condition? You can read on the feature proposal here https://hackmd.io/@chaosma/rkyPfI7Iq > if there...

Definitely the verifier contract could use an update - some good inspiration https://github.com/nocturne-xyz/protocol/blob/main/packages/circuits/scripts/genSolidityVerifier.ts