go-atlassian icon indicating copy to clipboard operation
go-atlassian copied to clipboard

Add ParentID as an option to Conf Page Create

Open squatched opened this issue 1 year ago • 6 comments

Fixes #210 by adding ParentID to create page request.

See https://developer.atlassian.com/cloud/confluence/rest/v2/api-group-page/#api-pages-post where parentId is an option for the request.

squatched avatar Jun 05 '23 21:06 squatched

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.25%. Comparing base (810da40) to head (588a6fc).

:exclamation: Current head 588a6fc differs from pull request most recent head 7547470. Consider uploading reports for the commit 7547470 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
+ Coverage   89.19%   89.25%   +0.05%     
==========================================
  Files         154      148       -6     
  Lines       12044    11626     -418     
==========================================
- Hits        10743    10377     -366     
+ Misses        659      632      -27     
+ Partials      642      617      -25     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 06 '23 17:06 codecov[bot]

Documentation PR: https://github.com/ctreminiom/go-atlassian-docs/pull/2

squatched avatar Jun 07 '23 17:06 squatched

closing pr due inactivity

ctreminiom avatar Aug 14 '23 05:08 ctreminiom

I'm sorry but what activity was needed? I don't see any feedback here and I've been using a custom build of go-atlassian using this PR for weeks now without issue. Is there something that needs to change?

squatched avatar Aug 15 '23 20:08 squatched

What needs to be done to get this merged? Anything I can help with?

squatched avatar Jan 26 '24 22:01 squatched

I'm not sure why this received the "breaking-change" label (I VAGUELY recall some comment somewhere with that term but I don't remember where it is and I just re-examined these changes and I don't see how adding a field to the PageCreatePayloadScheme struct that is labeled omitempty could be considered a breaking change as any existing declarations of the struct with it omitted will simply initialize to empty string and then that won't get passed to the API so default behavior is achieved). Could this get merged any time soon?

squatched avatar Apr 16 '24 19:04 squatched