annotate_models icon indicating copy to clipboard operation
annotate_models copied to clipboard

Unsupported Ruby version is used in integration tests

Open nard-tech opened this issue 3 years ago • 2 comments

Maybe related to #859

Ruby 2.4 is no longer supported and the support of the Ruby 2.5 series ends on March 2021.

So I'd like to bump Ruby version from 2.4 - 2.6 to 2.6 - 3.0.

As I reported on #859, I tried to fix broken CI in #858. At the same time I tried to fix this issue, but I could not fix entire problems due to other complicated reasons. So I did not bumped Ruby versions for CI (I closed #857).

cf. https://www.ruby-lang.org/en/news/2020/04/05/support-of-ruby-2-4-has-ended/

Codes

https://github.com/ctran/annotate_models/blob/70aba780b44c8fad14b76c2e051529a6c78299bc/.github/workflows/ci.yml#L17

Version

  • annotate version: 3.1.1
  • rails version: 5.2.4.1, 6.0.2.1
  • ruby version: 2.4, 2.5, 2.6

nard-tech avatar Mar 31 '21 14:03 nard-tech

Hi @nard-tech,

Can you check if https://github.com/ctran/annotate_models/pull/865 works for you ? :) The issue was the removal of mimemagic (0.3.4) see here

ocarta-l avatar Apr 06 '21 10:04 ocarta-l

Hi @ocarta-l Ok, I will check #865.

nard-tech avatar Apr 07 '21 07:04 nard-tech