annotate_models icon indicating copy to clipboard operation
annotate_models copied to clipboard

Published 20 hours ago • verified publisher icon ctran

[Fix #630] do not re-annotate when wrapper matches column_pattern

Open sashabelozerov opened this issue 5 years ago • 5 comments

Fixes https://github.com/ctran/annotate_models/issues/630

sashabelozerov avatar Oct 05 '19 10:10 sashabelozerov

thanks!

maxh avatar Oct 08 '19 15:10 maxh

Could you resolve the conflicts? Thanks.

ctran avatar Nov 09 '19 17:11 ctran

@ctran

1- CI / test (2.3.x) fails on "Setup Ruby" step. I cannot do anything with it from my end, please check. 2- Please explain if I should fix violations reported by Hound bot, because it still passes the check and Rubocop does not detect any offences with the current config.

sashabelozerov avatar Dec 15 '19 09:12 sashabelozerov

@sashabelozerov I fixed CI, if you rebase it should pass in Travis and Github. The Hound bot is new.

@ctran should it be a hard blocker? We already have Rubocop.

drwl avatar Dec 18 '19 00:12 drwl

@drwl Thanks, I've rebased the branch.

sashabelozerov avatar Dec 21 '19 17:12 sashabelozerov